fix: Left/right/outer joins should have nullable fields. #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
carlyeks
force-pushed
the
join-nullable-types
branch
2 times, most recently
from
a2e8680
to
0f31cb3
Compare
vbarua
reviewed
Jul 13, 2023
isthmus/src/test/java/io/substrait/isthmus/SubstraitRelNodeConverterTest.java
Outdated
Show resolved
Hide resolved
During a left, right, or outer join, some set of fields from input become nullable because they are optionally matched in the output. For a left join, the right fields become nullable. For a right join, the left fields become nullable. For an outer join, both sets become nullable. This test fails with assertions enabled in Calcite code because the left join should have nullable right types.
carlyeks
force-pushed
the
join-nullable-types
branch
from
0f31cb3
to
8771086
Compare
ajegou
pushed a commit
to ajegou/substrait-java
that referenced
this pull request
Mar 29, 2024
During a left, right, or outer join, some set of fields from input become nullable because they are optionally matched in the output. For a left join, the right fields become nullable. For a right join, the left fields become nullable. For an outer join, both sets become nullable.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During a left, right, or outer join, some set of fields from input become nullable because they are optionally matched in the output. For a left join, the right fields become nullable. For a right join, the left fields become nullable. For an outer join, both sets become nullable.
This test fails with assertions enabled in Calcite code because the left join should have nullable right types.