Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: properly support Options for Scalar/Aggregate/Window functions #278

Merged
merged 3 commits into from
Jul 11, 2024
Merged

fix: properly support Options for Scalar/Aggregate/Window functions #278

merged 3 commits into from
Jul 11, 2024

Commits on Jul 8, 2024

  1. fix: properly support Options for Scalar/Aggregate/Window functions 

    https://substrait.io/expressions/scalar_functions/#options
Options were supported in the Java classes but in most cases dropped when converting into protobuf

This
- fixes the protobuf conversion,
- adds a builder for FunctionOption
- adds a ExpressionCreator functions with options
- does some refactoring
    @Blizzara
    Blizzara committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    83ee2bf View commit details
    Browse the repository at this point in the history

  2. fix: spotlessApply

    @Blizzara
    Blizzara committed Jul 8, 2024
    Configuration menu
    Copy the full SHA
    e786345 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2024

  1. revert additional creators

    @Blizzara
    Blizzara committed Jul 10, 2024
    Configuration menu
    Copy the full SHA
    9aae3ec View commit details
    Browse the repository at this point in the history