ci: editorconfig updates #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Weird. CI still fails for the editorconfig check https://github.com/substrait-io/substrait-java/actions/runs/9781058298/job/27004211456?pr=280 even though those files haven't been modified recently. |
vbarua
force-pushed
the
vbarua/pin-editor-config-version
branch
from
e68543b
to
cd0a454
Compare
vbarua
force-pushed
the
vbarua/pin-editor-config-version
branch
from
cd0a454
to
9d991fc
Compare
vbarua
force-pushed
the
vbarua/pin-editor-config-version
branch
from
9d991fc
to
fd27c75
Compare
vbarua
commented
Jul 5, 2024
| : '//' ~[\r\n]* -> channel(HIDDEN) | ||
| ; | ||
| : '//' ~[\r\n]* -> channel(HIDDEN) | ||
| ; |
There was a problem hiding this comment.
I'm choosing spaces over tabs here because that it what is used in examples in the ANTLR repo
https://github.com/antlr/grammars-v4/tree/master
vbarua
commented
Jul 5, 2024
| @@ -19,3 +19,6 @@ trim_trailing_whitespace = unset | |||
|
|
|||
| [*.gradle.kts] | |||
| indent_size = 2 | |||
|
|
|||
| [.gitmodules] | |||
| indent_style = tab | |||
There was a problem hiding this comment.
.gitmodule has not been updated in 2 years, but the check is firing (and failing) now for some reason.
Adding an explicit configuration for .gitmodule.
|
Still not sure why editorconfig started checking these files only now. In any case:
|
EpsilonPrime
approved these changes
Jul 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.