Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: split unbounded bound into lower and upper #691

Closed
wants to merge 2 commits into from
Closed

feat: split unbounded bound into lower and upper #691

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
532b812
feat: split unbounded bound into lower and upper
EpsilonPrime Aug 23, 2024
56835a2
fixed typo
EpsilonPrime Aug 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions proto/substrait/algebra.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1147,26 +1147,28 @@
// Defines that the bound extends to or from the current record.
message CurrentRow {}

// Defines an "unbounded bound": for lower bounds this means the start
// of the partition, and for upper bounds this means the end of the
// partition.
message Unbounded {}
// Defines an "unbounded bound" to the start of the partition.
message Unbounded_Preceding {}

// Defines an "unbounded bound" to the end of the partition.
message Unbounded_Following {}

oneof kind {
// The bound extends some number of records behind the current record.
Preceding preceding = 1;

Check failure on line 1159 in proto/substrait/algebra.proto

View workflow job for this annotation

GitHub Actions / Check Protobuf 

Message name "Unbounded_Preceding" should be PascalCase, such as "UnboundedPreceding".
// The bound extends some number of records ahead of the current
// record.
Following following = 2;

Check failure on line 1162 in proto/substrait/algebra.proto

View workflow job for this annotation

GitHub Actions / Check Protobuf 

Message name "Unbounded_Following" should be PascalCase, such as "UnboundedFollowing".

// The bound extends to the current record.
CurrentRow current_row = 3;

// The bound extends to the start of the partition or the end of the
// partition, depending on whether this represents the upper or lower
// bound.
Unbounded unbounded = 4;
// The bound extends to the start of the partition.
Unbounded_Preceding unbounded_preceding = 4;

// The bound extends to the end of the partition.
Unbounded_Following unbounded_following = 5;
}
}
}
Expand Down
Loading