-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dynamic collections #559
Dynamic collections #559
Conversation
Please continue reviewing the parts which are not related with linting issues. Integrating Es lint with VSCode has not worked yet for me... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure you chose to render the tree is not very flexible. In your code the components are not very reusable. They rather follow a strict hierarchy. Imagine we will implement later the lazy loading feature that would be required on manifest and items level both. YOu would need to implement it twice because you have sepcial components for manifest and item sub trees.
A better approach would be general tree node components that can render recursively other tree node comps as children. Each node component can toggle it's children display if there are any. And later you just add the lazy loading function onto the children within that node component.
Our idea of having collections in collections would also come closer.
This PR aims to accomplish the following goals:
Add
Button