-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sale end without vesting date #152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also removes the date-dns dependency due to lack of timezones support.
This change was due to the server sending a unix timestamp which is in UTC and date-fns working based on the js Date class with always converts it to local time. Dayjs is now replacing every instance of date-fns.
This fixes the localhost network chain id and the default chain ID when no Env Variables are set.
This adds another state for when the vesting start date isn't available. It also fixes the refund amount and claimable values.
This overrides the Intl locales default behaviour.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
flaviocastro
added
enhancement
New feature or request
and removed
medium
small changes
labels
May 11, 2022
flaviocastro
changed the title
Feature/sale end without vesting date
Add sale end without vesting date
May 11, 2022
rafaelcruzazevedo
approved these changes
May 11, 2022
naps62
reviewed
May 11, 2022
packages/web/src/core/utils/dayjs.ts
Outdated
|
||
dayjs.extend(timezone); | ||
dayjs.extend(utc); | ||
dayjs.tz.setDefault('Europe/Lisbon'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the default be UTC?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the Vesting Start date unknown state as
VESTING_UNKNOWN
app state.It also fixes the aUSD to be displayed with
aUSD
instead of$
and forces the formatter to ignore the locale and always put the symbol at the end.Fixes #143.
Refs #106 for the claimable and refundable amounts.