Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implement highlight error handling #50

Merged
merged 4 commits into from
Oct 11, 2024
Merged

implement highlight error handling #50

merged 4 commits into from
Oct 11, 2024

Conversation

rccsousa
Copy link
Collaborator

@rccsousa rccsousa commented Oct 8, 2024 •
edited
Loading

why:

  • component wasn't handling null/undefined highglights, breaking upon a fresh install;
    how:
  • temporarily replaces the highlights with a placeholder;
  • also updates fetcher with cache: 'no-store' as the iteration on main does not handle new content properly;

@rccsousa
implement highlight error handling
66a14fb 
- component wasn't handling null/undefined highglights;
@rccsousa rccsousa marked this pull request as ready for review October 8, 2024 10:28
@rccsousa rccsousa requested a review from davelange October 8, 2024 10:28
@netlify Netlify
Copy link

netlify bot commented Oct 11, 2024 •
edited
Loading

❌ Deploy Preview for content-sub failed.

Name Link
🔨 Latest commit eddd2b3
🔍 Latest deploy log https://app.netlify.com/sites/content-sub/deploys/6709065fc44a0000093994f5

@rccsousa rccsousa merged commit a1383d4 into main Oct 11, 2024
1 of 5 checks passed
@rccsousa rccsousa deleted the rs/highlight-error-handling branch October 11, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@davelange davelange Awaiting requested review from davelange

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@rccsousa