improve navigation #58
Conversation
- created pills for 2 authors and 3+ authors; - moved Author pills to a single file located in Authors/AuthorPills; - fixed imports
✅ Deploy Preview for content-sub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
- make header correspond to page type, changing background and font colors based on the type of page it is inserted instead of being generic
- changed metadata generation, badges, favicons and open graphs, replacing payload boilerplate open graph and use content tailored to the content-sub project
|
@davelange i'll mark this as ready for review for now and move on to other smaller adjustments on a new PR as this one is already quite long, but navigation had many things needing fixing; will do a clean up pass soon |
| ); | ||
| } | ||
|
|
||
| export function TwoAuthorPill({ authors }) { |
There was a problem hiding this comment.
It would be easier if there's only 1 AuthorPill. You could continue having the TwoAuthorPill and VariousAuthorsPill, but I'd suggest only exporting one AuthorPill that receives a user array, checks the length, and internally decides if it should use SingleAuthor, TwoAuthor, or Various Author. That way when you use it elsewhere, you dont need to worry about how which version to use
There was a problem hiding this comment.
Great idea, i'll implement this, thanks
There was a problem hiding this comment.
done in 90ef400 ✅
- remake author pill as a standalone component; - use conditional rendering to make it fit one, two or more contributors;
why:
how: