setup talks page #60
Merged
setup talks page #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'react-youtube' will facilitate embeding youtube videos on the talks-and-roundtables page
this dependency parses URL from multiple video hosting platforms and fetches the video id, to facilitate video embedding
- fix positioning and responsiveness; - temporarily supress typescript warnings;
✅ Deploy Preview for content-sub ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
davelange
approved these changes
Oct 22, 2024
|
|
||
| {/* Content column */} | ||
| <div className={styles.videoPlayer}> | ||
| {videoID.service === "youtube" && ( |
There was a problem hiding this comment.
What are the other service options? One option would be for people to paste the embed link in the CMS, and we just render
<iframe width="560"
height="315"
src={talk.url}
…rs/setup-talks-page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
How:
Screenshots:
Styled page
Re-enabled Talks & Roundtables navbar button