feat: fptower and tests #1239
Merged
feat: fptower and tests #1239
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
puma314
reviewed
Aug 4, 2024
| @@ -0,0 +1,332 @@ | |||
| use crate::air::{BaseAirBuilder, MachineAir, Polynomial, SP1AirBuilder}; | |||
There was a problem hiding this comment.
Can you clean up the unused imports?
| } | ||
|
|
||
| #[derive(Default)] | ||
| pub struct FpAddAssignChip<P> { |
There was a problem hiding this comment.
I think you can have this struct be like this
pub struct FpOperationChip<P> {
pub operation: Operation
}
And then you can just have FpOperationCols that basically will compile all of the logic for add/mul
0xWOLAND
force-pushed
the
bhargav/fptower
branch
from
8b88ae7 to
49350b3
Compare
0xWOLAND
force-pushed
the
bhargav/fptower
branch
from
07d5242 to
c16be0f
Compare
tamirhemo
force-pushed
the
bhargav/fptower
branch
from
f2f4453 to
d1859d1
Compare
tamirhemo
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fp Tower precompiles: