Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use embedded alloc in example, docs typo #1945

Merged
merged 4 commits into from
Jan 17, 2025
Merged

chore: use embedded alloc in example, docs typo #1945

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
cb9bdf1
chore: ssz-withdrawls uses embedded
nhtyy Jan 17, 2025
e09eeed
chore: typo
nhtyy Jan 17, 2025
cfdf2df
fix: warning on elf name with no outdir
nhtyy Jan 17, 2025
4a5023e
fix: pr suggestions
nhtyy Jan 17, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion book/versioned_docs/version-4.0.0/developers/common-issues.md
View file
Open in desktop
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Succinct Rust toolchain is built on Ubuntu 22.04 for ARM machines, which links a newer version of libc than available on Ubuntu 20.04.

Original file line number Diff line number Diff line change
Expand Up @@ -151,4 +151,4 @@ This error may manifest as:
/lib/x86_64-linux-gnu/libc.so.6: version `GLIBC_2.32' not found
```
This most commonly happens in CI runners, it is recommended to bump the runner OS to 22.04,
the issue applies to all older linux distrubtions that dont have support for the same version of libc used to build it.
the issue applies to all older linux distrubtions that don't have support for the same version of libc used to build it.
2 changes: 1 addition & 1 deletion crates/build/src/build.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ pub fn execute_build_program(
std::fs::copy(&elf_path, &output_path)?;
}
} else if args.elf_name.is_some() {
println!("cargo:warning=ELF name is set but --output-directory is not used");
println!("cargo:warning=ELF name is set but --output-directory is not used, the ELF will be place in the `target/` directory");
}

print_elf_paths_cargo_directives(&target_elf_paths);
Expand Down
Loading
Loading