refactor(recursion): simplify as_array impl for public values
#1956
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcoratger
changed the title
as_array impl for public valuesas_array impl for public values
nhtyy
force-pushed
the
recursion/public-values
branch
from
0604281 to
97d2de5
Compare
|
@tcoratger Thanks, can you please fix CI? |
@leruaa done |
|
Thanks for the PR @tcoratger! Unfortunately we've decided not to move foward on this PR as we have this pattern in many spots in We hope to see you contribute to SP1 again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.