Issue 17 sqlite #35
Merged
Issue 17 sqlite #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ule for the Server to utilise. The wrapper consists of four API functions for initialising the database, setting up the sensor tables, inserting and selecting sensor data from the database. The selecting sensor data API allows for selecting data between two times (so a range of data can be retrieved). This will allow for the easy retrieve of sensor data when bulking up data for transmission. Basic unit tests are provided in test_serverdatabase.py.
The helper function _save_sensor_data_to_database saves the sensor data passed (in bulk) and then commits the database to file to ensure the sensor data is saved. Not sure if this is the most optimal way to do it (as saving this frequently could be performance heavy (?)). Someone to look into if performance becomes an issue.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The SQLite database functionality is ready. Only inserting is currently being utilised in the server. Selecting will be used in future updates, but these are outside of this branch purpose.