Implemented the Keep Alive RESTful configuration #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfiguration section of `config.xml`) and into the server as a whole. A small refactor had to be done to implement this. The RESTful callable function that serves the request now returns the response it wishes to respond back to the client with (as apposed to the previous request object having a dedicated respond function). This was done because the RESTful needs to check the _config["keep_alive"] parameter after the websocket send to know to close the websocket or not (which isn't possible in the `RestfulRequest` class instance).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The RESTful websocket closing after a response is now configurable through the
keep_aliveconfiguration inconfig.xml.closes #45