Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support email for MailDomain #678

Merged
merged 2 commits into from
Feb 10, 2025
Merged

Add support email for MailDomain #678

merged 2 commits into from
Feb 10, 2025

Conversation

sdemagny
Copy link
Contributor

@sdemagny sdemagny commented Feb 2, 2025

TODO:

  • tests
  • quel mail de support on renseigne pour les domaines existants ? ici

@sdemagny sdemagny force-pushed the sdem/resolve_domain_issue branch 3 times, most recently from 477e0d1 to 3678588 Compare February 3, 2025 15:17
@sdemagny sdemagny changed the title Resolve domain issues Allow to email support of a domain Feb 3, 2025
@sdemagny sdemagny force-pushed the sdem/resolve_domain_issue branch 3 times, most recently from af0bbda to 4ee227d Compare February 3, 2025 15:46
@sdemagny sdemagny linked an issue Feb 4, 2025 that may be closed by this pull request
@sdemagny sdemagny force-pushed the sdem/resolve_domain_issue branch 6 times, most recently from 2074275 to 3a805ae Compare February 6, 2025 12:04
@sdemagny sdemagny force-pushed the sdem/resolve_domain_issue branch 9 times, most recently from 0ef9d56 to 2411504 Compare February 7, 2025 14:00
@sdemagny sdemagny marked this pull request as ready for review February 7, 2025 14:01
@sdemagny sdemagny requested a review from qbey February 7, 2025 14:01
@sdemagny sdemagny force-pushed the sdem/resolve_domain_issue branch 3 times, most recently from b2f9459 to dabe0ab Compare February 7, 2025 16:07
@sdemagny sdemagny changed the title Allow to email support of a domain Add support email for MailDomain Feb 7, 2025
@elvoisin elvoisin requested review from elvoisin and removed request for elvoisin February 7, 2025 16:11
@sdemagny sdemagny requested a review from elvoisin February 7, 2025 16:14
@sdemagny sdemagny force-pushed the sdem/resolve_domain_issue branch from dabe0ab to 3b0c6d8 Compare February 7, 2025 21:06
CHANGELOG.md Outdated Show resolved Hide resolved
@@ -123,29 +133,6 @@ describe('ModalAddMailDomain', () => {
expect(mockPush).toHaveBeenCalledWith(`/mail-domains/domainfr`);
});

it('submits the form on key enter press', async () => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove this one ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We tried to fix it but we failed. But it works in real life!
Since a redesign is underway, we decided not to waste time on it.

@sdemagny sdemagny force-pushed the sdem/resolve_domain_issue branch from 3b0c6d8 to 9e0ab6e Compare February 10, 2025 09:49
@sdemagny sdemagny requested a review from qbey February 10, 2025 09:54
Add new field on MailDomain to allow contact support
if some actions are required to fix domain.
Add new field to give email of support to manage actions
required on domain.
@sdemagny sdemagny force-pushed the sdem/resolve_domain_issue branch from 9e0ab6e to d795754 Compare February 10, 2025 10:37
@sdemagny sdemagny merged commit d795754 into main Feb 10, 2025
19 checks passed
@sdemagny sdemagny deleted the sdem/resolve_domain_issue branch February 10, 2025 11:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants