-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support email for MailDomain #678
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
477e0d1
to
3678588
Compare
af0bbda
to
4ee227d
Compare
2074275
to
3a805ae
Compare
0ef9d56
to
2411504
Compare
b2f9459
to
dabe0ab
Compare
elvoisin
approved these changes
Feb 7, 2025
dabe0ab
to
3b0c6d8
Compare
qbey
reviewed
Feb 10, 2025
src/backend/mailbox_manager/management/commands/setup_dimail_db.py
Outdated
Show resolved
Hide resolved
src/backend/mailbox_manager/migrations/0019_fill_maildomain_support_email.py
Outdated
Show resolved
Hide resolved
src/backend/mailbox_manager/migrations/0020_alter_maildomain_support_email.py
Outdated
Show resolved
Hide resolved
@@ -123,29 +133,6 @@ describe('ModalAddMailDomain', () => { | |||
expect(mockPush).toHaveBeenCalledWith(`/mail-domains/domainfr`); | |||
}); | |||
|
|||
it('submits the form on key enter press', async () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove this one ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We tried to fix it but we failed. But it works in real life!
Since a redesign is underway, we decided not to waste time on it.
3b0c6d8
to
9e0ab6e
Compare
qbey
approved these changes
Feb 10, 2025
Add new field on MailDomain to allow contact support if some actions are required to fix domain.
Add new field to give email of support to manage actions required on domain.
9e0ab6e
to
d795754
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: