This repository has been archived by the owner on Jan 8, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4
[HOLD] Migration third run #543
Draft
mjgiarlo
wants to merge
24
commits into
main
Choose a base branch
from
migration-third-run
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
force-pushed
the
migration-third-run
branch
2 times, most recently
from
June 3, 2021 15:12
7581b3a
to
7dc4ebb
Compare
jcoyne
force-pushed
the
migration-third-run
branch
from
June 9, 2021 16:01
7dc4ebb
to
a3fa6ae
Compare
jcoyne
force-pushed
the
migration-third-run
branch
2 times, most recently
from
June 23, 2021 12:44
8aca24c
to
affc12d
Compare
By convention, use a file called "collection_druids.txt", which is a plain-text file containing a number of bare druids, one per line. This file is produced by copying a column of druids out of a spreadsheet maintained by the PO. This will filter both the collections and the items that are exported.
Prior this could be an array which does not respond to #find_each and winds up loading tons of data into memory. Monkeypatch AF to allow POSTing to Solr. Confirmed working. And prefer `#each` with `#find_each` which, when chained with `#where`, has unpredictable results. (Instead of operating on the ~4K items in the relation returned by `#where`, `#find_each` operated on all instances of the model.) To support this, add amother AF monkeypatch to use HTTP POST.
jcoyne
force-pushed
the
migration-third-run
branch
from
July 14, 2021 15:43
affc12d
to
e1a872b
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For @jcoyne
Directions at sul-dlss/happy-heron#1226