Merge pull request #1145 from sul-dlss/avoid_html_safe

Avoid the use of html_safe for the Stanford-only icon

.rubocop_todo.yml

@@ -1,6 +1,6 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2024-08-19 13:52:42 UTC using RuboCop version 1.65.1.
+# on 2024-08-19 17:28:43 UTC using RuboCop version 1.65.1.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new

app/components/bibliographic_component.rb

@@ -28,13 +28,16 @@ def middle_fields
                        mods.nestedRelatedItem(value_renderer: Purl::RelatedItemValueRenderer)
   end
 
+  # Adds the "Stanford only" red "S" if this is via the OCLC proxy
   def build_transformer(field)
     ->(value) { format_mods_html(value, field:) + with_stanford_only(value) }
   end
 
   def with_stanford_only(value)
     return unless value.downcase.include?('https://stanford.idm.oclc.org/login?url=')
 
-    '<span class="stanford-only-text"><span class="visually-hidden">Stanford only </span></span>'.html_safe
+    tag.span class: 'stanford-only-text' do
+      tag.span 'Stanford only', class: 'visually-hidden'
+    end
   end
 end