Selectively import ace editor. #765
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcoyne
approved these changes
Nov 1, 2023
dgcliff
added a commit
to NEU-Libraries/cerberus
that referenced
this pull request
Feb 15, 2024
…sul-dlss/purl#765 - Use stimilus to activate the editor on connect() with a data-controller. This allows us to appropiately use ImportMap, ditch public/ace, and have everything work with turbo with no need for a hard load.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs #757
The motivation is to avoid loading ace editor on every page to improve performance.
No ace.js:
Ace.js loaded:
