Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove popper js from importmap.rb #767

Closed
wants to merge 1 commit into from

Conversation

justinlittman
Copy link
Contributor

To the best I can tell it isn't used.

@jcoyne
Copy link
Contributor

jcoyne commented Nov 1, 2023

popper.js is a peer dependency of bootstrap. https://getbootstrap.com/docs/5.3/getting-started/javascript/#dependencies it looks like drop-downs, popovers and tooltips require this.

@justinlittman
Copy link
Contributor Author

If I'm not mistaken, all of those BS components are opt-in. And I don't see any indication that we've opted in to any of them.

@jcoyne
Copy link
Contributor

jcoyne commented Nov 1, 2023

@justinlittman I don't see anything about opting-in here: https://getbootstrap.com/docs/5.3/components/dropdowns/ All you have to do to opt in is to add the attribute data-bs-toggle="dropdown" to a DOM node.

@justinlittman
Copy link
Contributor Author

Dropdowns, popovers, and tooltips aren't used in purl. However, since it is a tiny library, I'm going to close.

@justinlittman justinlittman deleted the justinlittman-patch-1 branch November 2, 2023 11:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants