Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shorten the distance between metrics headings and counts #835

Closed
wants to merge 1 commit into from

Conversation

thatbudakguy
Copy link
Member

@thatbudakguy thatbudakguy commented Nov 28, 2023

requested by @amyehodge via slack. since we're only showing the one metric right now (and eventually only two), having the big padding in between the heading and count looks a little weird.

before:

Screenshot 2023-11-28 at 09 02 34

after:

Screenshot 2023-11-28 at 09 02 30

@justinlittman
Copy link
Contributor

Should this using the forthcoming table layout? It seems odd to be trying to layout a dl to look like a row.

@justinlittman
Copy link
Contributor

I think you'll find the need for this is obviated with the new design.

@amyehodge
Copy link
Collaborator

@justinlittman Agreed.

@justinlittman justinlittman deleted the metrics-display-padding branch December 5, 2023 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants