Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds new section and table layout components. #843

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Conversation

justinlittman
Copy link
Contributor

refs #799

Note that this uses the existing html for sections. For a proposed refactor of this see #842.

@@ -147,7 +147,7 @@ def collection_items_link
def schema_dot_org?
::Metadata::SchemaDotOrg.schema_type?(cocina_body)
end

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubocop

Copy link
Contributor

@jcoyne jcoyne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. Do you want to update the templates to use this component too?

@justinlittman
Copy link
Contributor Author

@jcoyne I thought about adding that to the PR, but it was going to make a mess of the redesign PR.

@justinlittman justinlittman merged commit a94ffa5 into main Dec 1, 2023
1 check passed
@justinlittman justinlittman deleted the new_components branch December 1, 2023 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants