Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporary placeholder before the embed loads. #849

Merged
merged 2 commits into from
Dec 6, 2023
Merged

Temporary placeholder before the embed loads. #849

merged 2 commits into from
Dec 6, 2023

Conversation

jcoyne
Copy link
Contributor

@jcoyne jcoyne commented Dec 4, 2023

This prevents the content from jumping around

@jcoyne jcoyne marked this pull request as ready for review December 4, 2023 22:06
This prevents the content from jumping around
@justinlittman justinlittman changed the title Temporary placeholder before the embed loads. [HOLD] Temporary placeholder before the embed loads. Dec 5, 2023
Copy link
Contributor

@justinlittman justinlittman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve pending review by @astridu.

@andrewjbtw
Copy link

Noting here that @astridu has signed off in Slack (this thread).

@jcoyne jcoyne changed the title [HOLD] Temporary placeholder before the embed loads. Temporary placeholder before the embed loads. Dec 6, 2023
@jcoyne jcoyne merged commit 0853b5b into main Dec 6, 2023
1 check passed
@jcoyne jcoyne deleted the placeholder branch December 6, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants