Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Marchland promo. #524

Merged
merged 2 commits into from
Jun 12, 2024
Merged

Add Marchland promo. #524

merged 2 commits into from
Jun 12, 2024

Conversation

md5i
Copy link
Contributor

@md5i md5i commented Jun 12, 2024

No description provided.

@md5i
Copy link
Contributor Author

md5i commented Jun 12, 2024

Looks like I didn't do something that I needed to do when adding the card? What did I miss? I ran update-languages.

(Better documentation for adding card entries would be appreciated.)

@sumpfork
Copy link
Owner

The failing test tries to tell you (perhaps in an obscure way):

assert len(cards) == num_cards_expected
E       assert 1018 == 1017
E        +  where 1018 = len(["Alms", "Amulet", "Artificer", "Ball", "Bonfire", "Borrow", ...])

So because you added a card the test needs to be updated with the expected number of cards (1018).

I'm not sure how useful this test is, but it does make us check that the card count is what we intended, or didn't change if we didn't intend to change it.

@sumpfork sumpfork self-requested a review June 12, 2024 17:19
@md5i
Copy link
Contributor Author

md5i commented Jun 12, 2024

Is that something that I, when submitting a pull request, should update when adding a card? I'm happy to add that to this PR, if so.

@sumpfork sumpfork merged commit 912e169 into sumpfork:master Jun 12, 2024
4 checks passed
@nickv2002 nickv2002 mentioned this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants