Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow empty Stylelint input on precommit #1040

Merged
merged 2 commits into from
Nov 16, 2024
Merged

Conversation

connor-baer
Copy link
Member

Purpose

When committing changes only to CSS files listed in .stylelintignore, Stylelint throws an error.

Approach and changes

  • Allow empty input to Stylelint on precommit

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

Copy link

changeset-bot bot commented Nov 16, 2024

🦋 Changeset detected

Latest commit: 4de49af

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup-oss/foundry Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Nov 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.72%. Comparing base (bb9e28f) to head (4de49af).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1040   +/-   ##
=======================================
  Coverage   65.72%   65.72%           
=======================================
  Files          29       29           
  Lines        1733     1733           
  Branches      146      146           
=======================================
  Hits         1139     1139           
  Misses        579      579           
  Partials       15       15           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer merged commit 650a2c6 into main Nov 16, 2024
8 checks passed
@connor-baer connor-baer deleted the fix/stylelint-no-match branch November 16, 2024 16:57
@connor-baer connor-baer mentioned this pull request Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant