Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Biome #982

Merged
merged 11 commits into from
Jun 22, 2024
Merged

Add support for Biome #982

merged 11 commits into from
Jun 22, 2024

Conversation

connor-baer
Copy link
Member

@connor-baer connor-baer commented Jun 22, 2024

Purpose

Biome is a fast formatter for JavaScript, TypeScript, JSX, and JSON that scores 97% compatibility with Prettier. It mirrors many but not all of ESLint's rules and doesn't support plugins yet, so it's best to use them in tandem.

Approach and changes

  • Export a Biome config that can be extended: @sumup-oss/foundry/biome
  • Disable Prettier when Biome is installed
  • Disabled ESLint rules that are covered by Biome
  • Add option to choose Biome when running foundry init

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

Copy link

changeset-bot bot commented Jun 22, 2024

🦋 Changeset detected

Latest commit: 8a28b86

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@sumup-oss/foundry Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Jun 22, 2024

Codecov Report

Attention: Patch coverage is 66.75603% with 124 lines in your changes missing coverage. Please review.

Project coverage is 58.86%. Comparing base (efd31df) to head (32c30cd).
Report is 1 commits behind head on canary.

Current head 32c30cd differs from pull request most recent head 8a28b86

Please upload reports for the commit 8a28b86 to get more accurate results.

Files Patch % Lines
src/cli/init.ts 0.00% 85 Missing ⚠️
src/configs/biome/index.ts 0.00% 16 Missing ⚠️
src/cli/run.ts 0.00% 7 Missing ⚠️
lint-staged.config.js 0.00% 3 Missing ⚠️
src/cli/defaults.ts 0.00% 2 Missing ⚠️
src/cli/index.ts 0.00% 2 Missing ⚠️
src/configs/index.ts 0.00% 2 Missing ⚠️
src/configs/eslint/config.ts 99.54% 1 Missing ⚠️
src/configs/eslint/index.ts 0.00% 1 Missing ⚠️
src/configs/husky/index.ts 0.00% 1 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           canary     #982      +/-   ##
==========================================
+ Coverage   55.43%   58.86%   +3.42%     
==========================================
  Files          29       29              
  Lines        2354     2555     +201     
  Branches      138      143       +5     
==========================================
+ Hits         1305     1504     +199     
- Misses       1031     1033       +2     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@connor-baer connor-baer changed the base branch from main to canary June 22, 2024 14:17
@connor-baer connor-baer marked this pull request as ready for review June 22, 2024 14:42
@connor-baer connor-baer requested a review from a team as a code owner June 22, 2024 14:42
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team June 22, 2024 14:42
@connor-baer connor-baer merged commit c2d2d68 into canary Jun 22, 2024
4 checks passed
@connor-baer connor-baer deleted the feature/biome branch June 22, 2024 14:42
This was referenced Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant