Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Finetune the Biome integration #989

Merged
merged 3 commits into from
Jul 8, 2024
Merged

Conversation

connor-baer
Copy link
Member

Purpose

Finetuning the Biome integration after testing the Foundry prerelease with Biome in a few projects.

Approach and changes

  • Disabled the noNegationElse Biome rule as the fixed code isn't always more readable
  • Disabled the @typescript-eslint/quotes ESLint rule as it conflicts with Biome's formatter
  • Removed the obsolete tooling scripts which were previously moved to the init CLI command

Definition of done

  • Development completed
  • Reviewers assigned
  • Unit and integration tests

@connor-baer connor-baer requested a review from a team as a code owner July 8, 2024 08:13
@connor-baer connor-baer requested review from pdrmdrs and removed request for a team July 8, 2024 08:13
Copy link

changeset-bot bot commented Jul 8, 2024

⚠️ No Changeset found

Latest commit: 3e4e502

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@connor-baer connor-baer merged commit 79379d7 into canary Jul 8, 2024
5 of 6 checks passed
@connor-baer connor-baer deleted the feature/biome-finetuning branch July 8, 2024 08:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant