Add presubmits warnings for commonly misused functions.

Change-Id: I0b9c673dfcb13e29d4a384c39e1721cdb7c2d231
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5591890
Reviewed-by: Daniel Cheng <[email protected]>
Commit-Queue: Erik Chen <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1309589}

PRESUBMIT.py

@@ -1976,6 +1976,27 @@ class BanRule:
       ),
       treat_as_error = False,
     ),
+    BanRule(
+      pattern = 'ProfileManager::GetLastUsedProfile',
+      explanation = (
+        'Most code should already be scoped to a Profile. Pass in a Profile* '
+        'or retreive from an existing entity with a reference to the Profile '
+        '(e.g. WebContents).'
+      ),
+      treat_as_error = False,
+    ),
+    BanRule(
+      pattern = (
+        r'/FindBrowserWithUiElementContext|'
+        r'FindBrowserWithTab|'
+        r'FindBrowserWithGroup'
+      ),
+      explanation = (
+        'Most code should already be scoped to a Browser. Pass in a Browser* '
+        'or retreive from an existing entity with a reference to the Browser.'
+      ),
+      treat_as_error = False,
+    ),
 )
 
 _DEPRECATED_SYNC_CONSENT_FUNCTION_WARNING = (

PRESUBMIT_test.py

@@ -2982,6 +2982,8 @@ def testBannedCppFunctions(self):
                ['params.ownership = Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET']),
       MockFile('some/cpp/problematic/file4.cc',
                ['params.ownership = Widget::InitParams::NATIVE_WIDGET_OWNS_WIDGET']),
+      MockFile('some/cpp/problematic/file5.cc',
+               ['Browser* browser = chrome::FindBrowserWithTab(web_contents)']),
     ]
 
     results = PRESUBMIT.CheckNoBannedFunctions(input_api, MockOutputApi())
@@ -2995,6 +2997,7 @@ def testBannedCppFunctions(self):
     self.assertTrue('some/cpp/problematic/file2.cc' in results[0].message)
     self.assertTrue('some/cpp/problematic/file3.cc' in results[0].message)
     self.assertTrue('some/cpp/problematic/file4.cc' in results[0].message)
+    self.assertTrue('some/cpp/problematic/file5.cc' in results[0].message)
     self.assertFalse('some/cpp/nocheck/file.cc' in results[0].message)
     self.assertFalse('some/cpp/nocheck/file.cc' in results[1].message)
     self.assertFalse('some/cpp/comment/file.cc' in results[0].message)