Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added concurrency limiter #246

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Added concurrency limiter #246

wants to merge 2 commits into from

Conversation

kevinejohn
Copy link

Fixes this issue: #245

facebook/react-native#27483

@sunnylqm
Copy link
Owner

Maybe use multiGet is a better way?

@kevinejohn
Copy link
Author

kevinejohn commented Apr 13, 2020 •
edited
Loading

Are you saying call storage.getIdsForKey and then batch multiGet in smaller amounts?

@sunnylqm
Copy link
Owner

Yes in that way there would be only one promise.

@kevinejohn
Copy link
Author

Unfortunately window.localStorage does not have that same multiGet function which would break the cross platform compatibility of this library. Any other ideas?

@sunnylqm
Copy link
Owner

sunnylqm commented Apr 13, 2020 •
edited
Loading

Make it conditional (use multiGet only if it's available)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kevinejohn @sunnylqm