Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make '_strip' function return as list not set. #280

Merged
merged 1 commit into from
May 1, 2024

Conversation

JoeZiminski
Copy link
Contributor

@JoeZiminski JoeZiminski commented May 1, 2024

PR Description

Closes #279. This PR changes the return type of _strip function in blog.py to a list rather than set. This ensures
the order of values specified in the blog (e.g. :author:) is maintained on the postlist.

@nabobalis
Copy link
Contributor

Thanks for the PR!

@nabobalis
Copy link
Contributor

Those CI fails are to be expected (I need to fix them separately).

@nabobalis
Copy link
Contributor

I will merge this and get a release out.

@nabobalis nabobalis merged commit 4f3fb62 into sunpy:main May 1, 2024
7 of 10 checks passed
@JoeZiminski
Copy link
Contributor Author

Awesome, thanks @nabobalis!

@nabobalis
Copy link
Contributor

0.11.9 should be out now, so you can test your blog with that version and see if that solves your problem.

@JoeZiminski
Copy link
Contributor Author

This is working great, thanks @nabobalis !

@nabobalis
Copy link
Contributor

Thank you for submitting the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use list rather than set when stripping values for postlist
2 participants