Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates from the package template #812

Merged
merged 2 commits into from
Jan 20, 2025
Merged

Updates from the package template #812

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70c7c11
Automatic package template update
Cadair Jan 20, 2025
8138856
Update cube.py
nabobalis Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .cruft.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"template": "https://github.com/sunpy/package-template",
"commit": "d6b86e07efa31959f43e99ba32d323cf76736a05",
"commit": "ff0522bc171a1fc63022ed2a371f70669173012e",
"checkout": null,
"context": {
"cookiecutter": {
Expand Down Expand Up @@ -32,7 +32,7 @@
".github/workflows/sub_package_update.yml"
],
"_template": "https://github.com/sunpy/package-template",
"_commit": "d6b86e07efa31959f43e99ba32d323cf76736a05"
"_commit": "ff0522bc171a1fc63022ed2a371f70669173012e"
}
},
"directory": null
Expand Down
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
repos:
# This should be before any formatting hooks like isort
- repo: https://github.com/astral-sh/ruff-pre-commit
rev: "v0.8.6"
rev: "v0.9.1"
hooks:
- id: ruff
args: ["--fix"]
Expand Down
2 changes: 1 addition & 1 deletion ndcube/utils/cube.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ def propagate_rebin_uncertainties(uncertainty, data, mask, operation, operation_
if operation in {np.sum, np.nansum, np.mean, np.nanmean}:
propagation_operation = np.add
# TODO: product was renamed to prod for numpy 2.0
elif operation in {np.prod, np.nanprod, np.prod if hasattr(np, "product") else np.prod}:
elif operation in {np.prod, np.nanprod}:
propagation_operation = np.multiply
else:
raise ValueError("propagation_operation not recognized.")
Expand Down
Loading