Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Add the possibility to define custom transport settings for the
http.Client
. Furthermore the renaming prevents stuttering (formerClient.clientTransport
)What is the current behavior?
Any information can be found in #39
What is the new behavior?
It is now possible to define custom transport behavior by setting
Client.Transport.Parent
:Additional information
Due to the behavior of
httpmock
used for testing, the implementedRoundTrip()
is not as clean as it could be. For testing withhttpmock
to work properlyhttp.DefaultTransport.RoundTrip()
must be called inRoundTrip()
inclient.go
.