-
Notifications
You must be signed in to change notification settings - Fork 223
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(edge-functions): add warning for edge-functions configuration #2984
Conversation
Pull Request Test Coverage Report for Build 12667649354Details
💛 - Coveralls |
This would fix the issue, but I wonder if we should rather move toward a more "isolation" approach with something like this in the docs for the edge functions:
Could also mention the I'm happy to close the PR and go toward this approach if we choose it instead. |
Two suggestions.
I'd prefer updating the docs to mention the suggested path for deno.json for deployment so it's less confusing for new users. |
Good spot for the I think the issue with the "convenience shortcut" is that it create the expectation that things will work the same way between all the ways you can define your deps. And even if we mention things in the docs, it's not the best for discovery. Here is what I would like to propose:
I've reworked things toward this and refactored a bit how we handle the "default path", and created a PR for the documentation here: supabase/supabase#31264 WDYT ? @sweatybridge @jgoux |
+1 with @sweatybridge on only updating the docs and explaining that one |
dismissing to prefer docs update #2984 (comment)
f28903d
to
6a7dd19
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed the PR to remove the "global fallback handling" and keep focus over:
- Providing warning and feedbacks if the function isn't configured the recommended way.
- Add empty
deno.jsonc
and.npmrc
template when runningfunction new
to setup user for success.
Co-authored-by: Han Qiao <[email protected]>
What kind of change does this PR introduce?
Closes: #2983
What is the new behavior?
Add a warning preventing about deprecated global deps use, and
import_map
usage:Here 3 functions,
hello-world
,hello-word2
,hello-word3
only one of them declare a validdeno.jsonc
deps, here the result:Additional context