Enforce non-null parameter to .eq #464
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soedirgo
approved these changes
Aug 24, 2023
|
Thanks!
Agreed, using |
Merged
|
🎉 This PR is included in version 1.8.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Currently,
.eq()allows null inputs but crucially it won't work, as you need to use.is()for null comparisons.This PR adds stronger typing to ensure that null values are not passed to
.eq(). Instead, you'll either have to do non-null assertion or a more proper method, like.is()or.eqNullable()(#463)Note: this is kind of a breaking change, but I think an extremely useful one and call sites where this causes errors should be fixed