Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(auth): change AuthClientID to Int to better visiblity of client usage #656

Merged
merged 1 commit into from
Feb 5, 2025

Conversation

grdsdev
Copy link
Collaborator

@grdsdev grdsdev commented Feb 4, 2025

This pull request introduces several changes to enhance logging capabilities and refactor the AuthClient class. The most important changes include modifying the AuthClientID type, adding a logger decorator, and updating the Dependencies structure to include a logger.

Enhancements to logging:

Refactoring AuthClient:

  • Sources/Auth/AuthClient.swift: Introduced a global client ID counter and updated the AuthClient initializer to increment and assign unique client IDs.

Updating dependencies:

Formatting improvements:

@coveralls
Copy link

Pull Request Test Coverage Report for Build 13136923081

Details

  • 15 of 17 (88.24%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 74.497%

Changes Missing Coverage Covered Lines Changed/Added Lines %
Sources/Helpers/SupabaseLogger.swift 0 2 0.0%
Totals Coverage Status
Change from base Build 13134609012: 0.04%
Covered Lines: 4998
Relevant Lines: 6709

💛 - Coveralls

@grdsdev grdsdev requested a review from dshukertjr February 4, 2025 14:29
@grdsdev grdsdev merged commit dea204f into main Feb 5, 2025
22 checks passed
@grdsdev grdsdev deleted the guilherme/fix-auth-client-id branch February 5, 2025 12:27
grdsdev added a commit that referenced this pull request Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants