Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly calculate max version in stress_test #208

Merged
merged 2 commits into from
May 14, 2024
Merged

Properly calculate max version in stress_test #208

merged 2 commits into from
May 14, 2024

Conversation

somtochiama
Copy link
Contributor

@somtochiama somtochiama commented May 14, 2024

This pull request calculates the max version for each node correctly at the end of stress tests and adds more logs to make it easier to figure out what caused the stress test to fail

Copy link

@sgrif sgrif left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but a more detailed description of what you're changing and why this fixes it in the commit message and/or PR description would be helpful 😄

crates/corro-agent/src/agent/tests.rs Outdated Show resolved Hide resolved
@somtochiama somtochiama changed the title Fix test logs Properly calculate max version in stress_test May 14, 2024
@somtochiama somtochiama merged commit b53edcc into main May 14, 2024
4 checks passed
@somtochiama somtochiama deleted the test-log branch May 14, 2024 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants