Remove changes that failed to process from seen map #230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jeromegn
requested changes
Jul 2, 2024
| error!("could not process multiple changes: {e}"); | ||
| for change in changes { | ||
| let v = *change.0.versions().start(); | ||
| seen_mutex.lock().remove(&(change.0.actor_id, v)); |
There was a problem hiding this comment.
Adding a mutex here is probably a bit harder than changing the return value of the future and handling it in the loop, in the tokio::select!.
For example, you could return BTreeMap<ActorId, RangeInclusiveSet<Version>> (or something) from the future. It would represent the data to remove from the seen map. You'd only do this if the function errored, else you return an empty BTreeMap (does not allocate).
| @@ -461,11 +473,8 @@ pub async fn handle_changes( | |||
|
|
|||
| // process these first, we don't care about the result, | |||
| // but we need to drain it to free up concurrency | |||
| res = join_set.join_next(), if !join_set.is_empty() => { | |||
| _ = join_set.join_next(), if !join_set.is_empty() => { | |||
There was a problem hiding this comment.
Here, you'd handle the map, remove every element present in it, from seen.
jeromegn
approved these changes
Jul 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.