Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keep gossip address the same as the actor address #257

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

runsisi
Copy link
Contributor

@runsisi runsisi commented Aug 29, 2024

No description provided.

@jeromegn
Copy link
Member

jeromegn commented Sep 2, 2024

Is that causing issues?

@runsisi
Copy link
Contributor Author

runsisi commented Sep 4, 2024

we store actor address (self.external_addr().unwrap_or_else(|| self.gossip_addr()))1 in __corro_members table2, while in spawn_swim_announcer to skip local node announce3 gossip address (gossip_server_endpoint.local_addr())4 is used as local address, i.e., our_addr. i think this is not correct.

maybe we should change generate_bootstrap 5 signiture to ignore skip both gossip address and external address?

Footnotes

  1. https://github.com/superfly/corrosion/blob/e35acab3f3d6bb5499104ddf3b3dda7245a2437a/crates/corro-types/src/agent.rs#L141

  2. https://github.com/superfly/corrosion/blob/e35acab3f3d6bb5499104ddf3b3dda7245a2437a/crates/corro-agent/src/broadcast/mod.rs#L709

  3. https://github.com/superfly/corrosion/blob/e35acab3f3d6bb5499104ddf3b3dda7245a2437a/crates/corro-agent/src/agent/bootstrap.rs#L39

  4. https://github.com/superfly/corrosion/blob/e35acab3f3d6bb5499104ddf3b3dda7245a2437a/crates/corro-agent/src/agent/run_root.rs#L56

  5. https://github.com/superfly/corrosion/blob/e35acab3f3d6bb5499104ddf3b3dda7245a2437a/crates/corro-agent/src/agent/bootstrap.rs#L16

@somtochiama
Copy link
Contributor

maybe we should change generate_bootstrap 5 signiture to ignore skip both gossip address and external address?

@runsisi I think this is a better solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants