Update log shipper docs to ensure that no public access is granted #930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we mention that if they want only 1 machines, then use the Related: this user PR for apps that do have 2 machines #820 |
|
Yes, actually this may be a related issue. The shipper can operate in HA mode by setting a |
|
#820 mentioned above was merged. this added info about QUEUE env var to the docs |
|
@jsierles Should we still ship this docs change or did it get fixed in flyctl? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A customer pointed out that our log shipper could expose its GraphQL API. We want standard shipper deployments to have no services nor IPs.
Note:
--no-public-ipsfails when an HTTP service is setup by default byfly launch.