feat: secrets unset-all #3994
Open
feat: secrets unset-all #3994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ref: superfly#3973 - desc: add runUnsetAll to secrets.New(); runUnsetAll uses client.GetAppSecrets, otherwise its the same code as runUnset
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
What and Why:
added functionality for 'fly secrets unset-all', which unsets all secrets with one command.
How:
TL:DR - added runUnsetAll to secrets.New(); runUnsetAll uses client.GetAppSecrets, otherwise its the same code as runUnset.
gets all secrets for the current fly app using client.GetAppSecrets. iterates thru to get the names and add to a string array, then calls UnsetSecretsAndDeploy from runUnset with the secrets. essentially the same code as runUnset, but getting secrets again using the same strategy as other components in the library.
i have tested multiple times on my deployments and it works like a charm!
Related to:
#3973
Documentation