avoid re-using stale state in parallel auth flows #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Separates transaction creation and resumption into explicitly separate functions that are called explicitly from the appropriate request handler in the provider, rather than create/resume being called in order in the base handler itself. There are no use-cases where both creation and resumption are expected to occur in a single request, so the previous implementation is bug-prone. Fixes: superfly#9
btoews
approved these changes
Oct 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Separates transaction creation and resumption into explicitly separate functions that are called explicitly from the appropriate request handler in the provider, rather than create/resume being called in order in the base handler itself.
There are no use-cases where both creation and resumption are expected to occur in a single request, so the previous implementation is bug-prone.
Fixes: #9