Added preloading of paywall's resources listed in manifest #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* providing cached resources in WebArchiveWebViewClient
ianrumac
force-pushed
the
develop
branch
3 times, most recently
from
043d458 to
3ff1589
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR are inspired by added support for
.webarchivefiles in iOS SDKThe
.webarchiveformat is not supported on Android..mht/.mhtmlrequires all the resources referenced in HTML to be included in the archive but not all of them are listed in the manifest. Thus the proposed custom solution.What is done
Paywall’s manifestWebArchiveaccording to manifest’susepreferenceWebArchivefrom fileWebArchiveaccording to manifest’susepreferenceWebArchiveWebViewClient: returning preloaded resources fromWebArchive, missing ones are fetched from server.