fix: max_in_use_session metric time

surbhigarg92 · Dec 26, 2024 · d61b4f3 · d61b4f3
1 parent ac1ddbc
commit d61b4f3
Showing 1 changed file with 11 additions and 0 deletions.
diff --git a/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPool.java b/google-cloud-spanner/src/main/java/com/google/cloud/spanner/SessionPool.java
@@ -2060,7 +2060,15 @@ void maintainPool() {
         }
         this.prevNumSessionsAcquired = SessionPool.this.numSessionsAcquired;
       }
+
+      // Reset the start time for recording the maximum number of sessions
+      // in the pool.
       Instant currTime = clock.instant();
+      if (currTime.isAfter(SessionPool.this.lastResetTime.plus(Duration.ofMinutes(10)))) {
+        SessionPool.this.maxSessionsInUse = SessionPool.this.numSessionsInUse;
+        SessionPool.this.lastResetTime = currTime;
+      }
+
       removeIdleSessions(currTime);
       // Now go over all the remaining sessions and see if they need to be kept alive explicitly.
       keepAliveSessions(currTime);
@@ -2309,6 +2317,9 @@ enum Position {
   @GuardedBy("lock")
   private int maxSessionsInUse = 0;
 
+  @GuardedBy("lock")
+  private Instant lastResetTime = Clock.INSTANCE.instant();
+
   @GuardedBy("lock")
   private long numSessionsAcquired = 0;