63-ansible-lint - [ansible] Add Ansible Lint #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Not sure why, but adding it causes all kinds of snapshot problems with LintTargetRequests - Looks like it's expected that everything is a full blown formatter, or a linter - not really a combo
|
Still missing some tests |
lilatomic
reviewed
Jun 16, 2022
There was a problem hiding this comment.
The logic looks good, I think there are a few minor problems:
- I think there's a problem with the config files, I don't think they're resolved recursively.
- the community.docker collection isn't installed, so ansible-lint aborts with that as a single error instead of doing the full lint
pants-plugins/experimental/ansible/lint/ansible_lint/subsystem.py
Outdated
Show resolved
Hide resolved
Yep, I went with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A modified subset of #54
Closes #63