Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LiveView 0.20.2+ #728

Closed
wants to merge 9 commits into from
Closed

LiveView 0.20.2+ #728

wants to merge 9 commits into from

Conversation

harmon25
Copy link
Contributor

@harmon25 harmon25 commented Jan 5, 2024

  • updates to lv 0.20.3
  • adds phoenix_html_helpers for compatibility
  • replaces uses of Phoenix.HTML.Form with PhoenixHTMLHelpers.Form

msaraiva and others added 3 commits January 3, 2024 16:27
@msaraiva
Fix Malformed HTML in rendered.js
5b8962b
@msaraiva
Fix error when passing special chars as literals inside an expression
4f8d84d
@harmon25
LiveView 0.20.2+ (#1)
0e32d0a 
* updates to lv 0.20.3
- adds `phoenix_html_helpers` for compatibility
- replaces uses of `Phoenix.HTML.Form` with `PhoenixHTMLHelpers.Form`
@dougw-bc dougw-bc mentioned this pull request Jan 5, 2024
Closed
@harmon25 harmon25 changed the base branch from main to fix-lv-20-compat January 5, 2024 14:43
@harmon25 harmon25 changed the title LiveView 0.20.2+ (#1) LiveView 0.20.2+ Jan 8, 2024
@harmon25 harmon25 changed the base branch from fix-lv-20-compat to main January 22, 2024 16:30
@tiagoefmoraes
Copy link
Member

@harmon25, thanks for the PR, I solved the context and attribute order issue in #733, we'll handle the update to phoenix_html 4.0.0 and phoenix_html_helpers soon.

@harmon25
Copy link
Contributor Author

@tiagoefmoraes Thanks!!

@harmon25 harmon25 closed this Jan 26, 2024
@tiagoefmoraes tiagoefmoraes mentioned this pull request Jan 30, 2024
Merged
@petermueller
Copy link

petermueller commented Feb 26, 2024 •
edited
Loading

@tiagoefmoraes, @harmon25, let me know if there's any help or testing needed for when resurrecting the phoenix_html_helpers changes comes back around for you all, and thank you for your work :)

(edit: I'm assuming this will be a part of the surface_form changes and eventual deprecation?)

@dan-klasson
Copy link

Any progress on supporting phoenix_html 4.0.0?

@pablopen
Copy link

looking forward to supporting phoenix_html 4.x.x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@harmon25 @tiagoefmoraes @petermueller @dan-klasson @pablopen @msaraiva