Juce plugin out of the repo (#1155)

It's still in history, but we are definitely wrapper committed
at this point. Onwards!

.github/workflows/build-release.yml

@@ -70,13 +70,7 @@ jobs:
       matrix:
         include:
           - name: Clap First
-            juce_style: FALSE
-            installer_name: ""
             installer_dir: clapfirst
-          #- name: Juce Style
-          #  juce_style: TRUE
-          #  installer_name: "OldJuceStyle-"
-          #  installer_dir: jucestyle
 
     steps:
       - name: Checkout code
@@ -89,7 +83,7 @@ jobs:
         with:
           username: ${{ github.actor }}
           token: ${{ secrets.GITHUB_TOKEN }}
-          cmakeArgs: -DSCXT_JUCE_CLASSIC_STYLE=${{ matrix.juce_style }} -DSCXT_EXTRA_INSTALLER_NAME="${{matrix.installer_name }}" -DCMAKE_BUILD_TYPE=Release -GNinja
+          cmakeArgs: -DCMAKE_BUILD_TYPE=Release -GNinja
           target: shortcircuit-installer
 
 

CMakeLists.txt

@@ -33,8 +33,6 @@ math(EXPR PART1 "${DAY_OF_YEAR} + 1")
 project(ShortcircuitXT VERSION 0.${PART0}.${PART1}.0 LANGUAGES C CXX ASM)
 set(ShortcircuitXT_VERSION ${PROJECT_VERSION})
 
-option(SCXT_JUCE_CLASSIC_STYLE "Use juse classic vs clap-first style" OFF)
-
 if (APPLE)
     enable_language(OBJC)
     enable_language(OBJCXX)

clients/CMakeLists.txt

@@ -1,38 +1,4 @@
 project(scxt-clients LANGUAGES CXX)
 
-
-if (${SCXT_JUCE_CLASSIC_STYLE})
-    message(STATUS "Building JUCE_CLASSIC style plugins")
-    add_subdirectory(juce-plugin)
-
-    if(DEFINED ENV{ASIOSDK_DIR} OR BUILD_USING_MY_ASIO_LICENSE)
-        if(BUILD_USING_MY_ASIO_LICENSE)
-            message(STATUS "** BUILD USING OWN ASIO LICENSE **")
-            message(STATUS "The resulting Shortcircuit XT standalone executable is not licensed for distribution!")
-            message(STATUS "Fetching ASIO SDK...")
-
-            set(ASIOSDK_DIR ${CMAKE_BINARY_DIR}/asio/asiosdk)
-            add_custom_target(scxt-get-local-asio)
-            add_custom_command(
-                TARGET scxt-get-local-asio
-                WORKING_DIRECTORY ${CMAKE_CURRENT_SOURCE_DIR}
-                COMMAND ${CMAKE_COMMAND} -E make_directory ${CMAKE_BINARY_DIR}/asio
-                COMMAND ${CMAKE_COMMAND} -D ASIO_SDK_DESTINATION=${CMAKE_BINARY_DIR}/asio -P ../cmake/get-asio.cmake
-            )
-            add_dependencies(scxt_plugin scxt-get-local-asio)
-        else()
-            file(TO_CMAKE_PATH "$ENV{ASIOSDK_DIR}" ASIOSDK_DIR)
-            message(STATUS "ASIO SDK found at ${ASIOSDK_DIR}")
-            message(STATUS "The resulting Shortcircuit XT standalone executable is not licensed for distribution!")
-        endif()
-
-        target_compile_definitions(scxt_plugin INTERFACE JUCE_ASIO=1)
-        target_include_directories(scxt_plugin INTERFACE ${ASIOSDK_DIR}/common)
-        set(JUCE_ASIO_SUPPORT TRUE)
-    endif()
-else()
-    message(STATUS "Building clap-first / wrapper plugins")
-    add_subdirectory(clap-first)
-endif()
-
+add_subdirectory(clap-first)
 add_subdirectory(sfz-token-dump)

clients/clap-first/CMakeLists.txt

@@ -1,5 +1,6 @@
 project(scxt_clapfirst)
 
+message(STATUS "Shortcircuit XT building clap-first wrappers")
 set(name "Shortcircuit XT")
 set(IMPL_TARGET ${PROJECT_NAME}_impl)
 add_library(${IMPL_TARGET} STATIC clap-config.cpp