Optimization: use a const & to avoid copy when traversing matrix (#129)

this substantially reduces the cost of a process with empty matrix
surge-synthesizer · Sep 14, 2024 · b6d11da · b6d11da
1 parent 8d266fb
commit b6d11da
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/include/sst/basic-blocks/mod-matrix/ModMatrix.h b/include/sst/basic-blocks/mod-matrix/ModMatrix.h
@@ -298,12 +298,12 @@ template <typename ModMatrixTraits> struct FixedMatrix : ModMatrix<ModMatrixTrai
         {
             matrixOutputs[outIdx] = this->baseValues.at(tgt);
         }
-        for (auto r : routingValuePointers)
+        for (const auto &r : routingValuePointers)
         {
-            if (r.active && !(*r.active))
+            if (!r.source || !r.target)
                 continue;
 
-            if (!r.source || !r.target)
+            if (r.active && !(*r.active))
                 continue;
 
             float sourceViaVal{1.f};