Placehodler on param placement #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a commit which just impacts Delay as I think about this problem a tad more. The problem of course is that Delay<Config>::delay_params requires a <Config> to actually get at the params enum, which isn't desirable, but we need a pattern by which we can get at them without a full config instance for things like specifying uis. Maybe So move the ennums out of the class for now into the namespace but I may revert this as I re-think.
baconpaul
added a commit
to baconpaul/sst-effects
that referenced
this pull request
Jul 18, 2024
This reverts commit d4d397a which turned out not to be needed.
baconpaul
added a commit
that referenced
this pull request
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a commit which just impacts Delay as I think about this problem a tad more. The problem of course is that Delay::delay_params requires a to actually get at the params enum, which isn't desirable, but we need a pattern by which we can get at them without a full config instance for things like specifying uis. Maybe
So move the ennums out of the class for now into the namespace but I may revert this as I re-think.