Add effects to the example, refactor some parts and rename it #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah one is 440 centered and one is 8.192 centered and it’s a bummer thank you for this! I’ll take a look tomorrow morning |
|
Yeah this is great! Merging! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The example has been renamed CLIExample.cpp
I've had to duplicate some of the code but factored as much as possible out of the example main function. I think it's not too bad that it ends up as 2 separate functions: for a dev ending up reading the code, it makes the separation between voice effects and the other effects clearer.
I have a question about ConcreteConfig and FxConfig, there is a difference in the (equal)NoteToPitch and noteToPitch functions: the latter is
pow(2.f, (f + 69) / 12.f)while the former misses the+ 69, afaik 69 corresponds to A4 == 440Hz.