Add Linear and Sine folds from Vital Synth #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baconpaul
reviewed
Sep 8, 2024
baconpaul
requested changes
Sep 8, 2024
|
The test failures have been there since we moved to GitHub actions. I would not worry about those. I should fix them. But the enum ordering needs to be cleaned before I can merge. I can do it in the AM if you don't get to it but if you are still at computer and can fix that'd be great. Thanks! |
knows to do that; clang-format
|
OK pushed that tweak and merged. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the Linear and Sine folds using similar techniques as those used in the Vital synthesizer (GPLv2). They look like this (picture taken from my Vitality fork, drive set to ~10.5 dB):
This was originally developed for use in my Vitality project (WIP), where I replaced vital's distorts with the SST ones.