Factory Tuning Library option properly reveals folder now (#4912)

Also renamed tuning-library folder to tuning_library for consistency,
and updated all the places in the codebase that referred to the old name.

Also update .clang-format file for clf version 12

.clang-format

@@ -6,15 +6,53 @@ Language: Cpp
 BasedOnStyle: LLVM
 IndentWidth: 4
 AlignAfterOpenBracket: Align
-BreakBeforeBraces: Allman
+BreakBeforeBraces: Custom
+BraceWrapping:
+  AfterCaseLabel:  true
+  AfterClass:      true
+  AfterControlStatement: Always
+  AfterEnum:       true
+  AfterFunction:   true
+  AfterNamespace:  true
+  AfterObjCDeclaration: true
+  AfterStruct:     true
+  AfterUnion:      true
+  AfterExternBlock: true
+  BeforeCatch:     true
+  BeforeElse:      true
+  BeforeLambdaBody: false
+  BeforeWhile:     false
+  IndentBraces:    false
+  SplitEmptyFunction: true
+  SplitEmptyRecord: true
+  SplitEmptyNamespace: true
 ColumnLimit: 100
 SortIncludes: false
 ---
 Language: ObjC
 BasedOnStyle: LLVM
 IndentWidth: 4
 AlignAfterOpenBracket: Align
-BreakBeforeBraces: Allman
+BreakBeforeBraces: Custom
+BraceWrapping:
+  AfterCaseLabel:  true
+  AfterClass:      true
+  AfterControlStatement: Always
+  AfterEnum:       true
+  AfterFunction:   true
+  AfterNamespace:  true
+  AfterObjCDeclaration: true
+  AfterStruct:     true
+  AfterUnion:      true
+  AfterExternBlock: true
+  BeforeCatch:     true
+  BeforeElse:      true
+  BeforeLambdaBody: false
+  BeforeWhile:     false
+  IndentBraces:    false
+  SplitEmptyFunction: true
+  SplitEmptyRecord: true
+  SplitEmptyNamespace: true
 ColumnLimit: 100
 SortIncludes: false
 ---

scripts/installer_win/surge-x86.iss

@@ -39,7 +39,7 @@ UninstallFilesDir={commonappdata}\Surge XT\uninstall\x86\
 
 [InstallDelete]
 Type: filesandordirs; Name: "{commoncf32}\VST3\Surge Synth Team\Surge XT Effects.vst3"
-;; clean up factory data folder, except tuning-library folder (users might link to their own custom tunings into this folder)
+;; clean up factory data folder, except tuning_library folder (users might link to their own custom tunings into this folder)
 Type: filesandordirs; Name: "{commonappdata}\Surge XT\modulator_presets"
 Type: filesandordirs; Name: "{commonappdata}\Surge XT\patches_3rdparty"
 Type: filesandordirs; Name: "{commonappdata}\Surge XT\patches_factory"

scripts/installer_win/surge.iss

@@ -41,7 +41,7 @@ UninstallFilesDir={commonappdata}\Surge XT\uninstall
 
 [InstallDelete]
 Type: filesandordirs; Name: "{commoncf64}\VST3\Surge Synth Team\Surge XT Effects.vst3"
-;; clean up factory data folder, except tuning-library folder (users might link to their own custom tunings into this folder)
+;; clean up factory data folder, except tuning_library folder (users might link to their own custom tunings into this folder)
 Type: filesandordirs; Name: "{commonappdata}\Surge XT\modulator_presets"
 Type: filesandordirs; Name: "{commonappdata}\Surge XT\patches_3rdparty"
 Type: filesandordirs; Name: "{commonappdata}\Surge XT\patches_factory"

src/gui/SurgeGUIEditor.cpp

@@ -2256,7 +2256,7 @@ juce::PopupMenu SurgeGUIEditor::makeTuningMenu(const juce::Point<int> &where, bo
         };
 
         auto scl_path =
-            Surge::Storage::appendDirectory(this->synth->storage.datapath, "tuning-library", "SCL");
+            Surge::Storage::appendDirectory(this->synth->storage.datapath, "tuning_library", "SCL");
 
         scl_path = Surge::Storage::getUserDefaultValue(&(this->synth->storage),
                                                        Surge::Storage::LastSCLPath, scl_path);
@@ -2310,7 +2310,7 @@ juce::PopupMenu SurgeGUIEditor::makeTuningMenu(const juce::Point<int> &where, bo
         };
 
         auto kbm_path = Surge::Storage::appendDirectory(this->synth->storage.datapath,
-                                                        "tuning-library", "KBM Concert Pitch");
+                                                        "tuning_library", "KBM Concert Pitch");
 
         kbm_path = Surge::Storage::getUserDefaultValue(&(this->synth->storage),
                                                        Surge::Storage::LastKBMPath, kbm_path);
@@ -2443,10 +2443,10 @@ juce::PopupMenu SurgeGUIEditor::makeTuningMenu(const juce::Point<int> &where, bo
                           [this]() { showHTML(this->tuningToHtml()); });
 
     tuningSubMenu.addItem(Surge::GUI::toOSCaseForMenu("Factory Tuning Library..."), [this]() {
-        auto dpath =
-            Surge::Storage::appendDirectory(this->synth->storage.datapath, "tuning-library");
+        auto path =
+            Surge::Storage::appendDirectory(this->synth->storage.datapath, "tuning_library");
 
-        juce::URL(juce::File(dpath)).launchInDefaultBrowser();
+        Surge::GUI::openFileOrFolder(path);
     });
 
     return tuningSubMenu;